Make it easier to override the default UriHandler #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can rely on a composition local and override it that way, or you can pass it in as an argument.
|
Thanks for your contribution. I don't prefer passing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can rely on a composition local and override it that way, or you can pass it in as an argument.
Personally, if it is only for a single View, I find composition locals to be a bit cumbersome to override.
From the issue #145 open about this already I think others might as well. This would give people the option to override it either through the local, or just by passing in an argument.
However I can definitely understand the feeling that this is simply redundant to the composition local, so feel free to close this PR if you don't like it.